Skip to content

chore(release): prepare 1.3.15（正式版版本号）+ 修复 bump 脚本误改依赖版本 - #893

Merged
appergb merged 2 commits into
betafrom
chore/bump-1.3.15
Aug 3, 2026
Merged

chore(release): prepare 1.3.15（正式版版本号）+ 修复 bump 脚本误改依赖版本#893
appergb merged 2 commits into
betafrom
chore/bump-1.3.15

Conversation

@appergb

@appergb appergb commented Aug 3, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator

User description

正式版 1.3.15 版本号同步（5 个文件一致）：

  • package.json / package-lock.json（root + nested）/ tauri.conf.json / Cargo.toml / Cargo.lock（openless 块）：1.3.15-Beta.4 → 1.3.15
  • 顺带修复 scripts/bump-version.sh 的 awk 潜在 bug：原实现匹配「第一个纯 X.Y.Z 版本行」，当 [package].version 带 -Beta.N 后缀时会误把 macOS keyring 依赖版本（3.6.3）改成新版本号——本次发布已手工纠正，脚本加 [package] 段锚定防再犯

合并后 beta 与 main 版本号一致，CI green 后即可推 v1.3.15-tauri 发正式版。

PR Type

Bug fix, Other

Description

  • Bump version from 1.3.15-Beta.4 to 1.3.15

  • Update package.json, Cargo.toml, tauri.conf.json

  • Fix bump-version.sh awk [package] anchoring

  • Prevent accidental dependency version replacement

Diagram Walkthrough

flowchart LR
  A["Release 1.3.15"] --> B["Update app manifests"]
  A --> C["Fix bump-version.sh"]
  B --> D["package.json"]
  B --> E["Cargo.toml"]
  B --> F["tauri.conf.json"]
  C --> G["Anchor [package] section"]
Loading

File Walkthrough
Relevant files
Bug fix
bump-version.sh
Anchor Cargo.toml version replacement to package                 

scripts/bump-version.sh

  • Added in_package state to awk script
  • Only replaces version inside [package] section
  • Added comments explaining keyring dependency risk
 +5/-2     
Configuration changes
package.json
Bump app package version to 1.3.15                                             

openless-all/app/package.json

  • Updated version from 1.3.15-Beta.4 to 1.3.15
 +1/-1     
Cargo.toml
Bump Cargo package version to 1.3.15                                         

openless-all/app/src-tauri/Cargo.toml

  • Updated [package] version from 1.3.15-Beta.4 to 1.3.15
 +1/-1     
tauri.conf.json
Bump Tauri config version to 1.3.15                                           

openless-all/app/src-tauri/tauri.conf.json

  • Updated version from 1.3.15-Beta.4 to 1.3.15
 +1/-1     

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Incomplete Fix

The new awk logic keeps in_package set for all sections after [package], and the version pattern only matches plain X.Y.Z values. If the current [package].version has a pre-release suffix (the exact case described in the PR), it will not be replaced, done stays unset, and the first plain dependency version in a later section (e.g. keyring 3.6.3) can still be overwritten. This PR makes the current repo safe by setting the package version to 1.3.15, but the script does not fully prevent the original bug for future pre-release bumps. Consider resetting in_package when a new TOML section header appears, or also matching [package].version values that include suffixes.

 
/^\[package\]$/ { in_package = 1 }
in_package && !done && /^version = "[0-9]+\.[0-9]+\.[0-9]+"$/ {
  sub(/"[0-9]+\.[0-9]+\.[0-9]+"/, "\"" new "\"")
  done = 1

@appergb
appergb merged commit a3d014b into beta Aug 3, 2026
5 checks passed
@appergb
appergb deleted the chore/bump-1.3.15 branch August 3, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@appergb